Make it easy to deploy on aws #75
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moubctez
reviewed
Jun 11, 2025
| @@ -9,3 +9,5 @@ data: | |||
| DEFGUARD_GRPC_URL: {{ .Values.grpcUrl | quote }} | |||
| DEFGUARD_STATS_PERIOD: {{ .Values.statsPeriod | quote }} | |||
| RUST_LOG: {{ .Values.logLevel | quote }} | |||
| PRE_UP: "iptables -t nat -A POSTROUTING -o eth0 -j MASQUERADE" | |||
There was a problem hiding this comment.
Is that necessary? Can we guarantee the network interface will always be eth0 for all users of this chart? Maybe it should be wrapped in AWS-only condition?
moubctez
reviewed
Jun 11, 2025
| @@ -56,6 +59,19 @@ spec: | |||
| name: {{ .Values.existingTokenSecret }} | |||
| key: {{ .Values.existingTokenSecretKey }} | |||
| {{- end }} | |||
| # used to keep nlb happy to do health checks at port 80. | |||
There was a problem hiding this comment.
It seems to be AWS-related only. Should be wrapped in a condition.
moubctez
reviewed
Jun 11, 2025
| selector: | ||
| {{- include "defguard-gateway.selectorLabels" . | nindent 4 }} | ||
|
|
||
| {{ end }} |
There was a problem hiding this comment.
Missing LineFeed (LF) characted at the end of the file
moubctez
reviewed
Jun 11, 2025
| type: ClusterIP | ||
| cloudProvider: aws |
There was a problem hiding this comment.
I think this should not be the default value.
|
Closing the issue due to inactivity |
github-project-automation
bot
moved this from Review
to Ready to release
in Backlog & Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.